----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102596/ -----------------------------------------------------------
(Updated Oct. 19, 2011, 1:04 p.m.) Review request for Amarok. Changes ------- * added missing files and directories to the patch Description ------- What works: * compiling, linking, installing ^^ * searching for items in the amazon store (set your location in the plugin settings first, Germany works atm, US and JP don't) * displaying the search results in the browser * adding stuff to the shopping cart and checking it out (no gui to view the cart or remove items yet) TODO: just grep for "TODO" in the patch. basically: language selection needs to be enforced, shopping cart functionality is not yet complete, adding preview streams to the playlist Any help is very appreciated. ^^ Also, I need artwork and I'm not an artist at all. Important: searching for items might take up to 30 seconds atm. This is going to improve to about 2 seconds once the cache of Amazon Item IDs on the server side has been filled. Those IDs are being cached forever. ;-) Diffs (updated) ----- src/browsers/CollectionTreeItemModelBase.cpp 119f90d src/core-impl/collections/support/MemoryQueryMakerInternal.h d3825ca src/core/collections/Collection.h 02b0894 src/core/collections/QueryMaker.h dfca79f src/services/CMakeLists.txt ad14fda src/services/ServiceCollection.h 7a57aa6 src/services/ServiceMetaBase.cpp 21587d3 src/services/amazon/Amazon.h PRE-CREATION src/services/amazon/AmazonActions.h PRE-CREATION src/services/amazon/AmazonActions.cpp PRE-CREATION src/services/amazon/AmazonCart.h PRE-CREATION src/services/amazon/AmazonCart.cpp PRE-CREATION src/services/amazon/AmazonCartItem.h PRE-CREATION src/services/amazon/AmazonCartItem.cpp PRE-CREATION src/services/amazon/AmazonCollection.h PRE-CREATION src/services/amazon/AmazonCollection.cpp PRE-CREATION src/services/amazon/AmazonConfig.h PRE-CREATION src/services/amazon/AmazonConfig.cpp PRE-CREATION src/services/amazon/AmazonConfigWidget.ui PRE-CREATION src/services/amazon/AmazonItemTreeModel.h PRE-CREATION src/services/amazon/AmazonItemTreeModel.cpp PRE-CREATION src/services/amazon/AmazonItemTreeView.h PRE-CREATION src/services/amazon/AmazonItemTreeView.cpp PRE-CREATION src/services/amazon/AmazonMeta.h PRE-CREATION src/services/amazon/AmazonMeta.cpp PRE-CREATION src/services/amazon/AmazonParser.h PRE-CREATION src/services/amazon/AmazonParser.cpp PRE-CREATION src/services/amazon/AmazonSettingsModule.h PRE-CREATION src/services/amazon/AmazonSettingsModule.cpp PRE-CREATION src/services/amazon/AmazonStore.h PRE-CREATION src/services/amazon/AmazonStore.cpp PRE-CREATION src/services/amazon/CMakeLists.txt PRE-CREATION src/services/amazon/amarok_service_amazonstore.desktop PRE-CREATION src/services/amazon/amarok_service_amazonstore_config.desktop PRE-CREATION src/services/amazon/images/CMakeLists.txt PRE-CREATION src/services/amazon/images/hover_info_magnatune.png PRE-CREATION Diff: http://git.reviewboard.kde.org/r/102596/diff/diff Testing ------- only in the German Amazon store. works. Screenshots ----------- Search result for "cure" in the German store http://git.reviewboard.kde.org/r/102596/s/311/ Thanks, Sven Krohlas
_______________________________________________ Amarok-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/amarok-devel
