----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102956/#review7587 -----------------------------------------------------------
Ship it! Done, commited as http://commits.kde.org/amarok/b4b59198a3b991df198a294f7abb1e2f6d945e56 (whith some slight modifications) Thanks for making Amarok better. Silver, plese mark this request as submitted, I don't (yet) have permissions to do so. - Matěj Laitl On Oct. 24, 2011, 5:55 p.m., Silver Juurik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102956/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2011, 5:55 p.m.) > > > Review request for Amarok. > > > Description > ------- > > The patch adds a keyboard shortcut for moving focus to collection search > input box. The default shortcut is ctrl+F. > > The idea is from a JJ: https://bugs.kde.org/show_bug.cgi?id=257381 > The keyboard shortcuts ctrl+J (an existing shortcut that moves focus to > playlist search box) and ctrl+F partially solve the problem described in the > bug. > > > Diffs > ----- > > src/browsers/collectionbrowser/CollectionWidget.h a206914 > src/browsers/collectionbrowser/CollectionWidget.cpp ace058a > src/MainWindow.h 076628f > src/MainWindow.cpp 2d2ebac > > Diff: http://git.reviewboard.kde.org/r/102956/diff/diff > > > Testing > ------- > > > Thanks, > > Silver Juurik > >
_______________________________________________ Amarok-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/amarok-devel
