----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102966/#review7639 -----------------------------------------------------------
Ship it! Looks like quite a few pretty ugly hacks are needed for proper iP* detection with the current mediadevice codebase. In the near future (post 2.5 release) we should together try to find a simpler and easier to maintain solution. Commit it now and I'll do some testing later. The patch certainly looks fine. - Bart Cerneels On Oct. 25, 2011, 1:20 p.m., Matěj Laitl wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102966/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2011, 1:20 p.m.) > > > Review request for Amarok, Christophe Giboudeaux and Bart Cerneels. > > > Description > ------- > > iPod connection assistant: rework iPod identification > > This should fix remaining bugs where iPod is misidentified as a USB > stick. Long comments are added that clarify interaction of varous > code paths that deal with iPhone-like devices. > > BUG: 263288 > REVIEW: TODO > FIXED-IN: 2.5 > > > Diffs > ----- > > ChangeLog a99a4de75b1941ecdc7cb3b41cce9ad3c996df27 > src/MediaDeviceCache.cpp 345837e34e5505c0900ee1a4e66ae9cf3deafa31 > > src/core-impl/collections/ipodcollection/support/IpodConnectionAssistant.cpp > fecd07a8db2cb3eead184ec3a12198fe02124074 > > Diff: http://git.reviewboard.kde.org/r/102966/diff/diff > > > Testing > ------- > > iPod nano 2G and iPod nano 4G are correctly identified. > > > Thanks, > > Matěj Laitl > >
_______________________________________________ Amarok-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/amarok-devel
