I think this should just be removed. Dead code is dead.
On Tue, Oct 25, 2011 at 17:47, Mark Kretschmann <kretschm...@kde.org> wrote: > Git commit 6c87c9b2a2e86fb4aac1cf9f0e83e1ce5d81a581 by Mark Kretschmann. > Committed on 25/10/2011 at 17:24. > Pushed by markey into branch 'master'. > > Add FIXME about unused variable. > > Anyone know what "viewMode" was supposed to do? > > M +1 -1 src/browsers/collectionbrowser/CollectionWidget.cpp > > http://commits.kde.org/amarok/6c87c9b2a2e86fb4aac1cf9f0e83e1ce5d81a581 > > diff --git a/src/browsers/collectionbrowser/CollectionWidget.cpp > b/src/browsers/collectionbrowser/CollectionWidget.cpp > index a2c3ead..d5d86c2 100644 > --- a/src/browsers/collectionbrowser/CollectionWidget.cpp > +++ b/src/browsers/collectionbrowser/CollectionWidget.cpp > @@ -165,11 +165,11 @@ CollectionWidget::CollectionWidget( const QString &name > , QWidget *parent ) > int enumValue = me.keyToValue( value.toLocal8Bit().constData() ); > enumValue == -1 ? d->viewMode = NormalCollections : d->viewMode = > (ViewMode) enumValue; > > + // FIXME Variable viewMode is never used. What was the intention? > ViewMode viewMode = NormalCollections; > if( enumValue != -1 ) > viewMode = (ViewMode) enumValue; > > - > // -- the search widget > d->searchWidget = new SearchWidget( hbox ); > d->searchWidget->setClickMessage( i18n( "Search collection" ) ); > _______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
