----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103213/#review8424 -----------------------------------------------------------
Ship it! Looks fine to me. - Kevin Funk On Nov. 23, 2011, 9:40 a.m., Andras Mantia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103213/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2011, 9:40 a.m.) > > > Review request for Amarok. > > > Description > ------- > > Sometimes Amarok just crashes (without playing everything), see > http://paste.kde.org/149438/ . The cause is sending a wrong dbus reply > message. The patch fixes it, creates and error *reply* message, instead of an > error message. > > > Diffs > ----- > > src/dbus/DBusQueryHelper.cpp 59985ce > > Diff: http://git.reviewboard.kde.org/r/103213/diff/diff > > > Testing > ------- > > > Thanks, > > Andras Mantia > >
_______________________________________________ Amarok-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/amarok-devel
