> On May 15, 2011, 11:12 a.m., Ralf Engels wrote: > > This request has been lying around unchanged for quite some time. > > > > The patch doesn't look that bad but what about the discussions? > > Nobody seemed to miss an "Add preset" button till now, so why add one? > > > > Can you summarize the latest state, update the patch and tell me if I > > should apply it?
Need some feedback or it will continue lying around forever. - Ralf ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100321/#review3331 ----------------------------------------------------------- On Jan. 8, 2011, 12:12 p.m., Philipp Schmidt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100321/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2011, 12:12 p.m.) > > > Review request for Amarok. > > > Description > ------- > > Fixes two errors: > > First: Presets are being saved explicitely, meaning they should persist even > when the Dialog is aborted/canceled. > Second: The state of the Current Collection Directory is saved regardless of > whether the Dialog was accepted or canceled. IMO it should only be saved like > all other values when it is accepted. > > > Diffs > ----- > > ChangeLog 3c337d1 > src/dialogs/OrganizeCollectionDialog.cpp b7d7850 > > Diff: http://git.reviewboard.kde.org/r/100321/diff/diff > > > Testing > ------- > > > Thanks, > > Philipp Schmidt > >
_______________________________________________ Amarok-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/amarok-devel
