On Tue, Jan 17, 2012 at 00:11, Matěj Laitl <ma...@laitl.cz> wrote: > On 11. 1. 2012 Bart Cerneels wrote: >> > With a small bit of work, UmsCollection could get support for: >> > * album covers if MetaFile::FileAlbum::{image(),hasImage()} is >> > implemented * compilations if MetaFile::FileAlbum::isCompilation() is >> > implemented (see ArtistHelper::bestGuessAlbumArtist()) >> > * track removing reflected in collection browser, call >> > MapChanger::removeTrack() perhaps somewhere in >> > UmsCollectionLocation::removeUrlsFromCollection() >> > * track metadata changes reflected in collection browser if you observe >> > tracks in UmsCollection and then call MapChanger::trackChanged() in >> > metadataChanged(). You should emit updated() when trackChanged() returns >> > true. Beware that it cannot currently cope with changes to track >> > uidUrl(). >> > >> > ChangeLog is not updated with above entries as the changes are not user- >> > visible anywhere in Amarok yet. >> >> It all looks completely sane and functional to me. Nice touch >> preventing possible threading issues in MemoryMeta. > > Okay, thanks for review, merged. > > Bart, do you plan to make the UmsCollection changes or should I add it to my > TODO list? >
I guess it will be faster if you implement it. Gives you a change to spot any mistakes in my coding as well. I'll probably have to little time the next few weeks anyway. _______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel