----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101836/#review9978 -----------------------------------------------------------
This review has been submitted with commit c0de954bda601a2e9c4d3464fcd4c5cb389541c2 by Ralf Engels to branch master. - Commit Hook On July 2, 2011, 4:55 p.m., Brendon Higgins wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101836/ > ----------------------------------------------------------- > > (Updated July 2, 2011, 4:55 p.m.) > > > Review request for Amarok. > > > Description > ------- > > Prevent FavoredRandomTrackNavigator choosing files chosen in recent past (fix > bug 244442). Heavily based on the way RandomTrackNavigator already does it - > i.e. generate recent history, and disqualifying those tracks from being > chosen (in this case, by assigning 0 weight). Indeed, parts are copied from > RandomTrackNavigator. This version of the patch applies to current HEAD (as > opposed to the patch I posted on the bug report). > > Myriam Schweingruber asked that I post it here. I claim that it /should/ work > as advertised - the approach is already working in RandomTrackNavigator - but > I've done no testing (I'm lucky to have found the time to do even /this/ > much). > > > This addresses bug 244442. > https://bugs.kde.org/show_bug.cgi?id=244442 > > > Diffs > ----- > > src/playlist/navigators/FavoredRandomTrackNavigator.h dafe48f > src/playlist/navigators/FavoredRandomTrackNavigator.cpp 44b8499 > > Diff: http://git.reviewboard.kde.org/r/101836/diff/diff > > > Testing > ------- > > > Thanks, > > Brendon Higgins > >
_______________________________________________ Amarok-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/amarok-devel
