----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104423/ -----------------------------------------------------------
Review request for Amarok. Description ------- In merged view, amarok merges the tracks if the tracks in an album have the same title even though they have different track number. It does not do so when shown collections separately. As far as I understand, the merged view is supposed to eliminate identical tracks - but tracks with different track numbers are obviously not identical. A couple of examples where album has more than one track with same name: - I have a concert recording where between the songs there are author's commentaries. Naturally, there are 11 tracks titled "Commentary" - Classical pieces often have parts titled by the tempo, e.g. track #2 "Allegro". Oftentimes there's more than one part with the same tempo in a piece. This patch adds track number to Meta::TrackKey class - the ProxyCollection class which implements merged view uses Meta::TrackKey to determine if tracks are identical. Diffs ----- src/core/meta/support/MetaKeys.h e2227e6 src/core/meta/support/MetaKeys.cpp 7f8ce7d Diff: http://git.reviewboard.kde.org/r/104423/diff/ Testing ------- Thanks, Alexey Neyman
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
