-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104480/#review12164
-----------------------------------------------------------
If this works for Last.fm this should to. I do remember problems with last.fm
when the wallet was not available though, so I wonder if all corner cases are
covered.
There are also so style errors in the copied code: there should be no space
between if and '('
if( bla )
{
}
I think the copyright header is ok. You probably don't even need the "from"
info, but in this case it's useful because there is no git trace.
- Bart Cerneels
On April 3, 2012, 8:04 p.m., Andrzej Hunt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104480/
> -----------------------------------------------------------
>
> (Updated April 3, 2012, 8:04 p.m.)
>
>
> Review request for Amarok.
>
>
> Description
> -------
>
> Modifies the Magnatune service to use KWallet for storage (instead of
> plaintext).
>
> The code has been copied from LastFmServiceConfig.cpp, with almost no
> modification on my part. (KDevelop removed some whitespace and reformatted
> some other bits of code meaning there are some formatting changes in the diff
> -- I apologise if this is a problem for reviewing, and I can revert the
> formatting changes if desired.)
>
> A question about copyright attribution: Would this be the correct thing to
> add to MagnatuneConfig.cpp below the current copyright line?
>
> * Code copied from ../lastfm/LastFmServiceConfig.cpp:
> * Copyright (c) 2007 Shane King <[email protected]>
>
> * Copyright (c) 2009 Leo Franchi <[email protected]>
>
>
> This addresses bug 242256.
> https://bugs.kde.org/show_bug.cgi?id=242256
>
>
> Diffs
> -----
>
> src/services/magnatune/MagnatuneConfig.cpp 18ee898
> src/services/magnatune/MagnatuneConfig.h f1d25eb
>
> Diff: http://git.reviewboard.kde.org/r/104480/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrzej Hunt
>
>
_______________________________________________
Amarok-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/amarok-devel
