----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105201/#review14599 -----------------------------------------------------------
One minor comment: Please don't remove copyright headers when copying files from another project--this is important for both legal and authorship (e.g. "who do I ask when this code doesn't work") reasons. The ScriptResolver.* files come from Tomahawk, and I'm totally happy with you re-using the code that we wrote. However, you need to retain the same copyright header that exists in the original source file, and additionally adding your own copyright if you modify the file. This is the original: https://github.com/tomahawk-player/tomahawk/blob/master/src/libtomahawk/resolvers/ScriptResolver.cpp This is also why the ScriptResolver class supports external .js and non-spotify resolvers. It'll work with any external process that implements the playdar + tomahawk extensions resolver API. thanks! - Leo Franchi On June 10, 2012, 7:10 a.m., Zhengliang Feng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105201/ > ----------------------------------------------------------- > > (Updated June 10, 2012, 7:10 a.m.) > > > Review request for Amarok. > > > Description > ------- > > Add Spotify collection code > > Currently implemented SpotifyCollection, SpotifyQueryMaker and > SpotifyMeta. The ScriptResolver is the class handles communcation with > standalone Spotify resolver, the code is mainly from original > ScriptResolver, but added more functions to handle messages separately. > > The controller class is used to start a ScriptResolver in a separate > thread and handles queries. > > > Diffs > ----- > > src/core-impl/collections/CMakeLists.txt > c78b9202ece71b51189c4e47d85acfa4a74ef8d6 > src/core-impl/collections/spotifycollection/CMakeLists.txt PRE-CREATION > src/core-impl/collections/spotifycollection/SpotifyCollection.h > PRE-CREATION > src/core-impl/collections/spotifycollection/SpotifyMeta.h PRE-CREATION > src/core-impl/collections/spotifycollection/SpotifyMeta.cpp PRE-CREATION > src/core-impl/collections/spotifycollection/SpotifyQueryMaker.h > PRE-CREATION > src/core-impl/collections/spotifycollection/SpotifyQueryMaker.cpp > PRE-CREATION > src/core-impl/collections/spotifycollection/support/Controller.h > PRE-CREATION > src/core-impl/collections/spotifycollection/support/Controller.cpp > PRE-CREATION > src/core-impl/collections/spotifycollection/support/QMFunctionTypes.h > PRE-CREATION > src/core-impl/collections/spotifycollection/support/Query.h PRE-CREATION > src/core-impl/collections/spotifycollection/support/ScriptResolver.h > PRE-CREATION > src/core-impl/collections/spotifycollection/support/ScriptResolver.cpp > PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/105201/diff/ > > > Testing > ------- > > Communication between ScriptResolver and Spotify resolver( from Tomahawk > resolver repo https://github.com/ofan/tomahawk-resolvers ). > Logging into Spotify using a username and password. > > > Thanks, > > Zhengliang Feng > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
