----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106370/#review18650 -----------------------------------------------------------
You should update https://git.reviewboard.kde.org/r/106366/ with these new changes and close this one. Will review there. For help to update the review-request ask on #amarok on irc.freenode.org. - Bart Cerneels On Sept. 7, 2012, 9:51 a.m., Daniel Stöckel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106370/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2012, 9:51 a.m.) > > > Review request for Amarok. > > > Description > ------- > > This is a followup to https://git.reviewboard.kde.org/r/106366/ > > Rhythmbox seems to require that the session-id field is present in a track > get request. > This patch adds an additional parameter to the DaapTrack class constructor > and appends the session id to the Track URL. > > > Diffs > ----- > > src/core-impl/collections/daap/DaapMeta.h 5278b57 > src/core-impl/collections/daap/DaapMeta.cpp a2429d7 > src/core-impl/collections/daap/daapreader/Reader.cpp b6196e1 > > Diff: http://git.reviewboard.kde.org/r/106370/diff/ > > > Testing > ------- > > - Tracks published by Rhythmbox now play correctly > - Daap collections published by mt-daap still work > > > Thanks, > > Daniel Stöckel > >
_______________________________________________ Amarok-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/amarok-devel
