Would be nice if somebody had a look at this
---------- Forwarded message ---------- From: Martin Blumenstingl <[email protected]> Date: Sun, Oct 21, 2012 at 11:49 AM Subject: [Bug 198381] Race condition when fetching lyrics To: [email protected] https://bugs.kde.org/show_bug.cgi?id=198381 --- Comment #21 from Martin Blumenstingl <[email protected]> --- Hi Myriam, I never wrote this code for the default lyrics script (as I was using the UltimateLyrics script back then instead of the default lyrics script we're talking about here). I think the UltimateLyrics developer used my steps from above to implement a fix. If anyone wants to take a look (I'm not using Amarok anymore, so I can't fix it): - Amarok.Lyrics.showLyrics() only works for the current track (that is *playing* at the time the lyrics are received) - if there is a short song where fetching lyrics takes a long time Amarok continues from track A (for which the lyrics were requested) to track B (which is now playing, where showLyrics is called). - using Amarok.Lyrics.setLyricsForTrack() is a safe way, because it sets the lyrics for a specific track (of which you need to know the URL). The lyrics applet is automatically updated if setLyricsForTrack() is called for the "currently playing" track (that was the fix I mentioned back then). -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Amarok-bugs-dist mailing list [email protected] https://mail.kde.org/mailman/listinfo/amarok-bugs-dist -- Proud member of the Amarok and KDE Community Protect your freedom and join the Fellowship of FSFE: http://www.fsfe.org Please don't send me proprietary file formats, use ISO standard ODF instead (ISO/IEC 26300) _______________________________________________ Amarok-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/amarok-devel
