----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108964/#review27540 -----------------------------------------------------------
Technically OK. This whole seek options bloat up the code a little and the many options bloat the configuration but still on the good side in my opinion. Can you add some text about the different keyboard modifiers. It's a little hard to figure out that there is even such a feature. src/configdialog/dialogs/PlaybackConfig.ui <http://git.reviewboard.kde.org/r/108964/#comment20670> Could you extend the whatsThis text to indicate what keyboard modificators you need to get a "short" "medium" and "long" seek. - Ralf Engels On Feb. 15, 2013, noon, Anmol Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108964/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2013, noon) > > > Review request for Amarok. > > > Description > ------- > > Added 3 different seek options with customizable seek durations which can be > set in the playback-config: > Control + L/R - Short seek > L/R - Normal/ Medium seek > Shift + L/R - Long seek > > > Diffs > ----- > > src/EngineController.h e9a8c26 > src/EngineController.cpp 3577acf > src/MainWindow.cpp 8f985dc > src/amarokconfig.kcfg 3ebf71d > src/configdialog/dialogs/PlaybackConfig.ui 3a79e43 > > Diff: http://git.reviewboard.kde.org/r/108964/diff/ > > > Testing > ------- > > > Thanks, > > Anmol Ahuja > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
