-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108995/
-----------------------------------------------------------
(Updated March 14, 2013, 11 p.m.)
Review request for Amarok.
Changes
-------
Hard-coded preamp label in UI.
Renamed attribute names to match Amarok coding style.
Added a " #define NUM_EQ_PARAM 11 " in EngineController.h . Please suggest a
better name for it.
Description
-------
1. Disabled Pre-amplifier in equalizer if it is not supported by phonon.
2. Fixed top and bottom labels of first slider. Earlier band name label was at
the top and slider value label was at the bottom for first slider.
3. Removed an extra semicolon EqualizerDialog.h .
Note : I have made an assumption that if at all preamp is present then it will
the first element of Effect Parameter list.
This addresses bug 301311.
https://bugs.kde.org/show_bug.cgi?id=301311
Diffs (updated)
-----
src/EngineController.h 5de4beb
src/EngineController.cpp 58d7360
src/dialogs/EqualizerDialog.h fd9032b
src/dialogs/EqualizerDialog.cpp 7d62e10
src/dialogs/EqualizerDialog.ui 43b0187
Diff: http://git.reviewboard.kde.org/r/108995/diff/
Testing
-------
All unit test cases passed.
Note : I have tested it with gstreamer only. Xine phonon keep crashing on my PC.
File Attachments
----------------
Equalizer snapshot
http://git.reviewboard.kde.org/media/uploaded/files/2013/02/17/equalizer.png
Thanks,
Harsh Gupta
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
