On 14. 3. 2013 Jasneet Bhatti wrote: > http://git.reviewboard.kde.org/r/109470/#review29229 > > While we wait for the active developers to decide if this feature is going > to be introduced, there are a few formatting issues to be addressed before > we proceed. As a rule, before you submit a patch, always make sure it > adheres to the coding style laid out in HACKING/intro_and_style.txt And > don't let this bother you too much, almost everyone has coding style issues > in their first patch.
Thank you very much for the preliminary review, this is much appreciated! It takes a lot of repetitive work from core developers (who can therefore give more time to actually review tricky parts of the logic). As a bonus, this keeps newcomers motivated, as they get rather responsive replies. I encourage you to review more of the patches from newcomers like this. :-) Matěj _______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel