> On July 2, 2013, 12:53 p.m., Matěj Laitl wrote: > > If it compiles with the const, it cannot hurt, ship it! > > Albert Astals Cid wrote: > Janitorial dude question: Has this been commited and you forgot to mark > it as submitted or it does still need submitting? >
I forgot to commit it, but it will be commited in my next reviewboard session as I have it starred. :) - Matěj ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110920/#review35438 ----------------------------------------------------------- On June 9, 2013, 9:53 p.m., Wolf-Michael Bolle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110920/ > ----------------------------------------------------------- > > (Updated June 9, 2013, 9:53 p.m.) > > > Review request for Amarok. > > > Description > ------- > > Fight warnings. > > Nobody will write that string after it has beed set. > > > Diffs > ----- > > src/services/mp3tunes/libmp3tunes/harmony.h > e0941e348db09ba69c39426077b6798e758d6354 > > Diff: http://git.reviewboard.kde.org/r/110920/diff/ > > > Testing > ------- > > > Thanks, > > Wolf-Michael Bolle > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel