----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114752/#review46778 -----------------------------------------------------------
Looks better, please see another round of suggestions below and also: 1. Add commit tags to the description - see quickgit.kde.org/?p=kdelibs.git&a=blob&f=.commit-template - namely: BUG: ####, FIXED-IN: 2.9, REVIEW: ### - so that they end up in the commit - also please update the description to be current 2. Add a line to the ChangeLog file (top-level in the repo) - under BUGFIXES on top. src/widgets/MetaQueryWidget.cpp <https://git.reviewboard.kde.org/r/114752/#comment33409> Another thing on my mind: it may have sense to have the format localized - please see KLocale class http://api.kde.org/4.x-api/kdelibs-apidocs/kdecore/html/classKLocale.html and perhaps ask on #kde-i18n IRC channel on Freenode. src/widgets/MetaQueryWidget.cpp <https://git.reviewboard.kde.org/r/114752/#comment33408> I see no point in allowing only 23:59:59, just make it 24:00:00 please, unless there is a usability problem with it. (and please update other places to match) - Matěj Laitl On Jan. 3, 2014, 6:33 p.m., Abhay Sombanshi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114752/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2014, 6:33 p.m.) > > > Review request for Amarok. > > > Bugs: 291400 > https://bugs.kde.org/show_bug.cgi?id=291400 > > > Repository: amarok > > > Description > ------- > > CollectionBrowser filter dialog will now allow a length of 2:59:59 hours. > > > Diffs > ----- > > src/widgets/MetaQueryWidget.cpp 58601cc > > Diff: https://git.reviewboard.kde.org/r/114752/diff/ > > > Testing > ------- > > works as expected. > > > Thanks, > > Abhay Sombanshi > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
