> On Sept. 28, 2014, 9:45 a.m., Matěj Laitl wrote: > > The change looks good (it is an improvement wrt current situation), but > > perhaps we can do what you envisioned on the bug, i.e. pause instantenously > > when pause is pressed within pausin fadeout?
I have experimented with that a bit. One problem I haven't been able to resolve is that if I make it pause before the fadeout is finished, when I press play again the fadeout hasn't reset, so for the first few moments it plays at a lower volume. Though I should mention that I don't know anything about Phonon, so me not knowing how to do it doesn't say much about how difficult it actually is. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120399/#review67549 ----------------------------------------------------------- On Sept. 28, 2014, 12:39 a.m., Martin Lyth wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120399/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2014, 12:39 a.m.) > > > Review request for Amarok. > > > Bugs: 339470 > https://bugs.kde.org/show_bug.cgi?id=339470 > > > Repository: amarok > > > Description > ------- > > Don't call play or pause if we're already waiting on the timer to pause. See > Bug 339470 for details on the bug, and the 1.5 lines of code are pretty > self-explanatory. > > > Diffs > ----- > > src/EngineController.cpp 19c483d > > Diff: https://git.reviewboard.kde.org/r/120399/diff/ > > > Testing > ------- > > Still compiles, and pressing pause continuously no longer extends the timer > infinitely. > > > Thanks, > > Martin Lyth > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
