Gary,
> If the purpose of penpals is to deliver desired (but spammy) mail that
> otherwise may not get delivered, then this should be more like:
> $penpals_threshold_high = $sa_kill_level_deflt + $penpals_bonus_score;
It has just this semantics, read the definition again:
$penpals_threshold_high ... when SA score (prior to boosts) lowered
by $penpals_bonus_score is still above $penpals_threshold_high, then
pen pals lookup will not be performed to save time, as it could not
influence blocking of spam; usual choice for value would be kill level
other reasonably high value; undef lets the threshold be ignored
and is a default (useful for testing and statistics gathering);
The code is:
if (defined($sql_storage) && $pp_bonus > 0 && $pp_halflife > 0 &&
$sender ne '' && [EMAIL PROTECTED] &&
(!defined($penpals_threshold_low)
|| $spam_level >= $penpals_threshold_low) &&
(!defined($penpals_threshold_high)
|| $spam_level-$pp_bonus <= $penpals_threshold_high) &&
# don't trust senders from outside using a local domain address:
($msginfo->client_addr_mynets ||
!lookup(0,$sender,@{ca('local_domains_maps')}))
) { ... do the lookup
I rewrote the text already twice, but is probably still confusing.
Better explanation is welcome.
> I was also thinking that if $penpals_threshold_high is not defined, then
> the default could be calculated like this, as there is no point in
> processing here if the processing has no net effect (cannot help the
> outcome).
One may be interested in results post-festum, perhaps for
statistical purposes or analyzing inter-user relationships,
or just plain curiosity what a final score would be.
> But then again, if someone is using procmail to count stars, who knows
> whether it will affect the outcome or not. Also, an additional
> calculation does take a few CPU cycles, so in some situations adding a
> calculation would increase overhead.
or if users have different kill levels.
Mark
_______________________________________________
AMaViS-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/amavis-user
AMaViS-FAQ:http://www.amavis.org/amavis-faq.php3
AMaViS-HowTos:http://www.amavis.org/howto/
