On 05/21/2007 07:24 PM, Mark Martinec wrote:
>> I've encountered problems concerning mails DISCARDed by amavis.
>> Some mailers (e.g. SurfControl RiskFilter) will interpret the SMTP
>> status code 254 used by amavis as a temporary error.
> 
> This is direct violation of a MUST in rfc2822, complain to the vendor.

Yes, I'll do.

[...]
>> Although section 4.2.5 suggests that any 2yz code in reply to a DATA
>> command transfers responsibility for mail-delivery to the receiver,
>> maybe using the existing code 250 and thus sending
>> "250 2.7.0 Ok, discarded ..."
>> whould be a safer way of signalling that the mail will be accepted but
>> discarded.
> 
> You are quite right, turning:
>   554 5.7.0 Ok, discarded, id=... - VIRUS: ...
> into:
>   254 2.7.0 Ok, discarded, id=... - VIRUS: ...
> is not good practice (violates a SHOULD),
> it should be:
>   250 2.7.0 Ok, discarded, id=... - VIRUS: ...
> 
> The following patch fixes it:
>
> --- amavisd~  Mon Apr 23 05:25:30 2007
> +++ amavisd   Mon May 21 19:10:15 2007
> @@ -9017,5 +9017,6 @@
>          if ($final_destiny == D_DISCARD) {
>            local($1,$2);
> -          $status =~ s{^5(\d\d) 5(\.\d\.\d)\z}{2$1 2$2};  # 5xx -> 2xx
> +        # $status =~ s{^5(\d\d) 5(\.\d\.\d)\z}{2$1 2$2};  # 5xx -> 2xx
> +          $status =~ s{^5(\d\d) 5(\.\d\.\d)\z}{250 2$2};  # 5xx -> 250
>          }
>          my($response) = $status . ' ' .

Thanks, I did already apply exactly that fix. (Including the comment. ;))

Cheers,
--leo
-- 
e-mail   ::: Alexander.Bergolth (at) wu-wien.ac.at
fax      ::: +43-1-31336-906050
location ::: Computer Center | Vienna University of Economics | Austria


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
AMaViS-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/amavis-user
AMaViS-FAQ:http://www.amavis.org/amavis-faq.php3
AMaViS-HowTos:http://www.amavis.org/howto/

Reply via email to