Updated Branches: refs/heads/branch-1.2.5 a46d35bf7 -> e8fe782b2
AMBARI-2716. Disable autocomplete on form tag for Ambari UI. (jaimin via yusaku) Project: http://git-wip-us.apache.org/repos/asf/incubator-ambari/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-ambari/commit/e8fe782b Tree: http://git-wip-us.apache.org/repos/asf/incubator-ambari/tree/e8fe782b Diff: http://git-wip-us.apache.org/repos/asf/incubator-ambari/diff/e8fe782b Branch: refs/heads/branch-1.2.5 Commit: e8fe782b231fed3d8750f55b283f31b0f1c78e42 Parents: a46d35b Author: Yusaku Sako <[email protected]> Authored: Tue Jul 30 13:20:04 2013 -0700 Committer: Yusaku Sako <[email protected]> Committed: Tue Jul 30 13:20:04 2013 -0700 ---------------------------------------------------------------------- ambari-web/app/models/form.js | 2 ++ ambari-web/app/templates/common/configs/addPropertyWindow.hbs | 2 +- ambari-web/app/templates/common/configs/capacity_scheduler.hbs | 2 +- ambari-web/app/templates/common/configs/overrideWindow.hbs | 2 +- ambari-web/app/templates/common/configs/service_config.hbs | 2 +- ambari-web/app/templates/main/admin/user/create.hbs | 2 +- ambari-web/app/templates/main/admin/user/edit.hbs | 2 +- ambari-web/app/templates/main/dashboard/edit_widget_popup.hbs | 2 +- ambari-web/app/templates/main/mirroring/dataset.hbs | 2 +- ambari-web/app/templates/main/mirroring/testConnection.hbs | 2 +- ambari-web/app/templates/main/mirroring/testConnectionResults.hbs | 2 +- ambari-web/app/templates/wizard/step1.hbs | 2 +- ambari-web/app/templates/wizard/step1_addLocalRepository.hbs | 2 +- ambari-web/app/templates/wizard/step5.hbs | 2 +- ambari-web/app/views/common/configs/services_config.js | 2 +- ambari-web/app/views/wizard/step0_view.js | 2 ++ 16 files changed, 18 insertions(+), 14 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-ambari/blob/e8fe782b/ambari-web/app/models/form.js ---------------------------------------------------------------------- diff --git a/ambari-web/app/models/form.js b/ambari-web/app/models/form.js index 50630c9..5b678de 100644 --- a/ambari-web/app/models/form.js +++ b/ambari-web/app/models/form.js @@ -23,6 +23,8 @@ App.Form = Em.View.extend({ * generating fields from fieldsOptions */ classNames:["form-horizontal"], + attributeBindings: ['autocomplete'], + autocomplete: 'off', i18nprefix:'form.', fields:[], field:{}, http://git-wip-us.apache.org/repos/asf/incubator-ambari/blob/e8fe782b/ambari-web/app/templates/common/configs/addPropertyWindow.hbs ---------------------------------------------------------------------- diff --git a/ambari-web/app/templates/common/configs/addPropertyWindow.hbs b/ambari-web/app/templates/common/configs/addPropertyWindow.hbs index 098bd3f..162034b 100644 --- a/ambari-web/app/templates/common/configs/addPropertyWindow.hbs +++ b/ambari-web/app/templates/common/configs/addPropertyWindow.hbs @@ -15,7 +15,7 @@ * See the License for the specific language governing permissions and * limitations under the License. }} - <form class="form-horizontal"> + <form class="form-horizontal" autocomplete="off"> <div class="each-row"> <label class="control-label">Type</label> <div class="controls"> http://git-wip-us.apache.org/repos/asf/incubator-ambari/blob/e8fe782b/ambari-web/app/templates/common/configs/capacity_scheduler.hbs ---------------------------------------------------------------------- diff --git a/ambari-web/app/templates/common/configs/capacity_scheduler.hbs b/ambari-web/app/templates/common/configs/capacity_scheduler.hbs index ccee91f..0c1f56d 100644 --- a/ambari-web/app/templates/common/configs/capacity_scheduler.hbs +++ b/ambari-web/app/templates/common/configs/capacity_scheduler.hbs @@ -66,7 +66,7 @@ <div class="row-fluid"> <div class="span8"> <div><strong>{{t admin.advanced.title}}</strong></div> - <form class="form-horizontal"> + <form class="form-horizontal" autocomplete="off"> {{#each view.advancedConfigs}} {{#if isVisible}} <div class="row-fluid"> http://git-wip-us.apache.org/repos/asf/incubator-ambari/blob/e8fe782b/ambari-web/app/templates/common/configs/overrideWindow.hbs ---------------------------------------------------------------------- diff --git a/ambari-web/app/templates/common/configs/overrideWindow.hbs b/ambari-web/app/templates/common/configs/overrideWindow.hbs index 21a021f..badb276 100644 --- a/ambari-web/app/templates/common/configs/overrideWindow.hbs +++ b/ambari-web/app/templates/common/configs/overrideWindow.hbs @@ -17,7 +17,7 @@ }} {{! #with view.categoryConfigProperty}} - <form class="form-horizontal"> + <form class="form-horizontal" autocomplete="off"> <div class="override-controls"> <h4 class="message">{{t hosts.selectHostsDialog.message}}</h4> {{#if view.parentView.warningMessage}} http://git-wip-us.apache.org/repos/asf/incubator-ambari/blob/e8fe782b/ambari-web/app/templates/common/configs/service_config.hbs ---------------------------------------------------------------------- diff --git a/ambari-web/app/templates/common/configs/service_config.hbs b/ambari-web/app/templates/common/configs/service_config.hbs index 9f1635f..6fea0b0 100644 --- a/ambari-web/app/templates/common/configs/service_config.hbs +++ b/ambari-web/app/templates/common/configs/service_config.hbs @@ -62,7 +62,7 @@ <div class="accordion-body collapse in"> <div class="accordion-inner service-config-section"> - <form class="form-horizontal"> + <form class="form-horizontal" autocomplete="off"> {{#each view.filteredCategoryConfigs}} <div {{bindAttr class=":entry-row isOverridden:overridden-property"}}> http://git-wip-us.apache.org/repos/asf/incubator-ambari/blob/e8fe782b/ambari-web/app/templates/main/admin/user/create.hbs ---------------------------------------------------------------------- diff --git a/ambari-web/app/templates/main/admin/user/create.hbs b/ambari-web/app/templates/main/admin/user/create.hbs index 82b51b5..cba744f 100644 --- a/ambari-web/app/templates/main/admin/user/create.hbs +++ b/ambari-web/app/templates/main/admin/user/create.hbs @@ -16,7 +16,7 @@ * limitations under the License. }} -<form class="form-horizontal"> +<form class="form-horizontal" autocomplete="off"> {{#each field in view.userForm.fields}} {{#unless field.isHidden}} <div {{bindAttr class="field.errorMessage:error :control-group"}}> http://git-wip-us.apache.org/repos/asf/incubator-ambari/blob/e8fe782b/ambari-web/app/templates/main/admin/user/edit.hbs ---------------------------------------------------------------------- diff --git a/ambari-web/app/templates/main/admin/user/edit.hbs b/ambari-web/app/templates/main/admin/user/edit.hbs index 437fea1..374a947 100644 --- a/ambari-web/app/templates/main/admin/user/edit.hbs +++ b/ambari-web/app/templates/main/admin/user/edit.hbs @@ -16,7 +16,7 @@ * limitations under the License. }} -<form class="form-horizontal"> +<form class="form-horizontal" autocomplete="off"> {{#each field in view.userForm.fields}} {{#unless field.isHidden}} <div {{bindAttr class="field.errorMessage:error :control-group"}}> http://git-wip-us.apache.org/repos/asf/incubator-ambari/blob/e8fe782b/ambari-web/app/templates/main/dashboard/edit_widget_popup.hbs ---------------------------------------------------------------------- diff --git a/ambari-web/app/templates/main/dashboard/edit_widget_popup.hbs b/ambari-web/app/templates/main/dashboard/edit_widget_popup.hbs index bf6d00c..201910f 100644 --- a/ambari-web/app/templates/main/dashboard/edit_widget_popup.hbs +++ b/ambari-web/app/templates/main/dashboard/edit_widget_popup.hbs @@ -15,7 +15,7 @@ * See the License for the specific language governing permissions and * limitations under the License. }} -<form class="form-horizontal"> +<form class="form-horizontal" autocomplete="off"> <div class="each-row"> <div class="alert alert-info"> {{view.configPropertyObj.hintInfo}} http://git-wip-us.apache.org/repos/asf/incubator-ambari/blob/e8fe782b/ambari-web/app/templates/main/mirroring/dataset.hbs ---------------------------------------------------------------------- diff --git a/ambari-web/app/templates/main/mirroring/dataset.hbs b/ambari-web/app/templates/main/mirroring/dataset.hbs index 33e0414..7212386 100644 --- a/ambari-web/app/templates/main/mirroring/dataset.hbs +++ b/ambari-web/app/templates/main/mirroring/dataset.hbs @@ -15,7 +15,7 @@ * See the License for the specific language governing permissions and * limitations under the License. }} -<div class="pull-left dataset-form"> +<div class="pull-left dataset-form" autocomplete="off"> <form class="form-horizontal"> <div class="add-data-set"> <table> http://git-wip-us.apache.org/repos/asf/incubator-ambari/blob/e8fe782b/ambari-web/app/templates/main/mirroring/testConnection.hbs ---------------------------------------------------------------------- diff --git a/ambari-web/app/templates/main/mirroring/testConnection.hbs b/ambari-web/app/templates/main/mirroring/testConnection.hbs index 6534ae9..1ab9174 100644 --- a/ambari-web/app/templates/main/mirroring/testConnection.hbs +++ b/ambari-web/app/templates/main/mirroring/testConnection.hbs @@ -16,7 +16,7 @@ * limitations under the License. }} -<form class="form-horizontal"> +<form class="form-horizontal" autocomplete="off"> <div class="add-cluster-1"> <div class="add-cluster-1-1"> <h4>Enter the URLs for the following</h4> http://git-wip-us.apache.org/repos/asf/incubator-ambari/blob/e8fe782b/ambari-web/app/templates/main/mirroring/testConnectionResults.hbs ---------------------------------------------------------------------- diff --git a/ambari-web/app/templates/main/mirroring/testConnectionResults.hbs b/ambari-web/app/templates/main/mirroring/testConnectionResults.hbs index 19d8ff5..4c88f94 100644 --- a/ambari-web/app/templates/main/mirroring/testConnectionResults.hbs +++ b/ambari-web/app/templates/main/mirroring/testConnectionResults.hbs @@ -16,7 +16,7 @@ * limitations under the License. }} -<form class="form-horizontal"> +<form class="form-horizontal" autocomplete="off"> <div class="add-cluster-2"> <table> http://git-wip-us.apache.org/repos/asf/incubator-ambari/blob/e8fe782b/ambari-web/app/templates/wizard/step1.hbs ---------------------------------------------------------------------- diff --git a/ambari-web/app/templates/wizard/step1.hbs b/ambari-web/app/templates/wizard/step1.hbs index 44f5ad9..9995e51 100644 --- a/ambari-web/app/templates/wizard/step1.hbs +++ b/ambari-web/app/templates/wizard/step1.hbs @@ -20,7 +20,7 @@ {{t installer.step1.body}} </p> <p><b>{{t common.stacks}}</b></p> -<form> +<form autocomplete="off"> {{#each stack in view.stacks}} <label class="radio">{{view view.stackRadioButton contentBinding="stack"}} {{stack.name}}</label> {{/each}} http://git-wip-us.apache.org/repos/asf/incubator-ambari/blob/e8fe782b/ambari-web/app/templates/wizard/step1_addLocalRepository.hbs ---------------------------------------------------------------------- diff --git a/ambari-web/app/templates/wizard/step1_addLocalRepository.hbs b/ambari-web/app/templates/wizard/step1_addLocalRepository.hbs index 1a1ec95..dcc3598 100644 --- a/ambari-web/app/templates/wizard/step1_addLocalRepository.hbs +++ b/ambari-web/app/templates/wizard/step1_addLocalRepository.hbs @@ -15,7 +15,7 @@ * See the License for the specific language governing permissions and * limitations under the License. }} - <form class="form-horizontal" id="addLocalRepositoryPopup"> + <form class="form-horizontal" id="addLocalRepositoryPopup" autocomplete="off"> <div class="each-row"> <label class="control-label">{{t installer.step1.advancedRepo.localRepo.label.os}}</label> <div class="controls"> http://git-wip-us.apache.org/repos/asf/incubator-ambari/blob/e8fe782b/ambari-web/app/templates/wizard/step5.hbs ---------------------------------------------------------------------- diff --git a/ambari-web/app/templates/wizard/step5.hbs b/ambari-web/app/templates/wizard/step5.hbs index 1c691a1..e98938f 100644 --- a/ambari-web/app/templates/wizard/step5.hbs +++ b/ambari-web/app/templates/wizard/step5.hbs @@ -26,7 +26,7 @@ </div> <div class="assign-masters"> <div class="select-hosts"> - <form class="form-horizontal"> + <form class="form-horizontal" autocomplete="off"> <!-- View for array controller --> {{#each servicesMasters}} <div class="control-group"> http://git-wip-us.apache.org/repos/asf/incubator-ambari/blob/e8fe782b/ambari-web/app/views/common/configs/services_config.js ---------------------------------------------------------------------- diff --git a/ambari-web/app/views/common/configs/services_config.js b/ambari-web/app/views/common/configs/services_config.js index 711e158..59f2682 100644 --- a/ambari-web/app/views/common/configs/services_config.js +++ b/ambari-web/app/views/common/configs/services_config.js @@ -1138,7 +1138,7 @@ App.ServiceConfigCapacityScheduler = App.ServiceConfigsByCategoryView.extend({ }), bodyClass: Ember.View.extend({ template: Ember.Handlebars.compile([ - '<form class="form-horizontal pre-scrollable">{{#each view.parentView.content.configs}}', + '<form class="form-horizontal pre-scrollable" autocomplete="off">{{#each view.parentView.content.configs}}', '{{#if isVisible}}', '<div class="row-fluid control-group">', ' <div {{bindAttr class="errorMessage:error :control-label-span :span4"}}>', http://git-wip-us.apache.org/repos/asf/incubator-ambari/blob/e8fe782b/ambari-web/app/views/wizard/step0_view.js ---------------------------------------------------------------------- diff --git a/ambari-web/app/views/wizard/step0_view.js b/ambari-web/app/views/wizard/step0_view.js index d9f2b15..11bbcc3 100644 --- a/ambari-web/app/views/wizard/step0_view.js +++ b/ambari-web/app/views/wizard/step0_view.js @@ -22,6 +22,8 @@ var App = require('app'); App.WizardStep0View = Em.View.extend({ tagName: "form", //todo: why form? + attributeBindings: ['autocomplete'], + autocomplete: 'off', templateName: require('templates/wizard/step0'), //todo: create property for placeholder(go to template)
