[
https://issues.apache.org/jira/browse/AMBARI-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13570906#comment-13570906
]
Sumit Mohanty commented on AMBARI-1260:
---------------------------------------
LGTM.
JMXHostProvider
Line 42 - Nit, Get the port for the given cluster name and component name
Line 44 - Nit, add clusterName to the javadoc.
AbstractProviderModule
Line 191 - Nit, !currVersion.equals(oldVersion) will remove the need for null
check
Line 197 - Hashmap is not synchronized. Aren't we allowing multiple threads to
do put which may result in inconsistency
Line 417 - We return "version1" as the default value. Is there always a config
with version name "version1"?
> Remove hard coded JMX port mappings
> -----------------------------------
>
> Key: AMBARI-1260
> URL: https://issues.apache.org/jira/browse/AMBARI-1260
> Project: Ambari
> Issue Type: Improvement
> Components: controller
> Affects Versions: 1.2.1
> Reporter: Siddharth Wagle
> Assignee: Siddharth Wagle
> Fix For: 1.3.0
>
> Attachments: AMBARI-1260.patch
>
>
> The JMXPropertyProvider contains a map of component names to ports ...
> {code}
> JMX_PORTS.put("NAMENODE", "50070");
> JMX_PORTS.put("DATANODE", "50075");
> JMX_PORTS.put("JOBTRACKER", "50030");
> JMX_PORTS.put("TASKTRACKER", "50060");
> JMX_PORTS.put("HBASE_MASTER", "60010");
> {code}
> These ports can change in configuration. Need to create the mapping
> dynamically.
> This is required for secure HDP cluster to work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
