[ 
https://issues.apache.org/jira/browse/AMBARI-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13702764#comment-13702764
 ] 

Yusaku Sako commented on AMBARI-2590:
-------------------------------------

Thanks [~xiwang0309].
Just a minor nit, but since reformatting afterwards makes it difficult to 
review/may create unnecessary clean JIRAs in the future... let's follow the 
standard coding convention.
Specifically:
* Variable names should be camel-cased ("obj_class" should be "objClass").
* "if(App.testMode) {" should be "if (App.testMode) {".
* "}else{" should be "} else {".

Please review 
https://cwiki.apache.org/confluence/display/AMBARI/Coding+Guidelines+for+Ambari 
and  http://javascript.crockford.com/code.html
                
> JS Error when delete a widget after sorting it on remove/edit sign
> ------------------------------------------------------------------
>
>                 Key: AMBARI-2590
>                 URL: https://issues.apache.org/jira/browse/AMBARI-2590
>             Project: Ambari
>          Issue Type: Bug
>            Reporter: Xi Wang
>            Assignee: Xi Wang
>         Attachments: AMBARI-2590.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to