[ 
https://issues.apache.org/jira/browse/AMBARI-3364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781596#comment-13781596
 ] 

Sumit Mohanty commented on AMBARI-3364:
---------------------------------------

LGTM, +1.

> Refactor the Role enum into a regular class
> -------------------------------------------
>
>                 Key: AMBARI-3364
>                 URL: https://issues.apache.org/jira/browse/AMBARI-3364
>             Project: Ambari
>          Issue Type: Task
>          Components: controller
>            Reporter: Nate Cole
>            Assignee: Nate Cole
>             Fix For: 1.5.1
>
>         Attachments: AMBARI-3364.patch
>
>
> In order to facilitate new services without having to change code, move the 
> {{Role}} enum to a class.  Add's "enum like" methods to it to maintain 
> existing code as much as possible: such as static {{values()}}, 
> {{valueOf(String)}} and non-static {{name()}}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to