[ 
https://issues.apache.org/jira/browse/AMBARI-3600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13807958#comment-13807958
 ] 

Nate Cole commented on AMBARI-3600:
-----------------------------------

* ConfigHelper
** Will update comment to be more clear
** hasPropertyFor() - This is required because we need to check to see if a 
property is stale for ANY OTHER service than the SCH that we are checking, 
because the OTHER one will be considered stale.  That check is designed to look 
forcustom properties that are assigned to a type but are not defined as part of 
the stack.  For example, if you assign a value to core-site that is undefined 
in any stack, any service relying on core-site will be considered stale.
** findChangedKeys() - it's ok for overlap in this case, because even 
overlapping (two properties defined in two different services) means it's stale.
** The method is (more or less) directly tested in 
ServiceComponentHostTest.testStaleConfigs() as you mentioned.
* StackServiceResponse
** TT/JT - the stack service response only indicates what configs a service 
defines, not the relationship of components to the config.  Any stale config 
value will make both TT and JT stale.
* ServiceInfo
** Will add synchronization to the method, but note that ServiceInfo is 
effectively singleton-per-stack, and no other synch activity happens around 
stacks as it is today.
* testStaleConfigs() addresses the SCHTest you mentioned.  Will switch to 2.0.6 
and verify.

> Add stale_configs attribute to a host_component response
> --------------------------------------------------------
>
>                 Key: AMBARI-3600
>                 URL: https://issues.apache.org/jira/browse/AMBARI-3600
>             Project: Ambari
>          Issue Type: Task
>            Reporter: Nate Cole
>            Assignee: Nate Cole
>             Fix For: 1.4.2
>
>         Attachments: AMBARI-3600.patch
>
>
> Add an intelligent check to determine if the configs are stale on a 
> host_component.  The response will have like the following:
> {noformat}
> {
>   "href" : 
> "http://localhost:8080/api/v1/clusters/c1/hosts/h1/host_components/DATANODE?fields=HostRoles/stale_configs";,
>   "HostRoles" : {
>     "cluster_name" : "c1",
>     "component_name" : "DATANODE",
>     "host_name" : "h1",
>     "stale_configs" : true
>   }
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to