[ https://issues.apache.org/jira/browse/AMBARI-3548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13818156#comment-13818156 ]
Sumit Mohanty commented on AMBARI-3548: --------------------------------------- Overall looks good. Some preliminary comments: * We can define SERVICE_CHECK as a command. As its not a custom command it need not be in the service spec. Alternatively, DECOMMISSION_DATANODE is a good candidate for a custom command. When HDFS moves to the new service spec structure we can wire it up correctly. * In the new HBASE spec, can we add DECOMMISSION_REGIONSERVER as a custom command. I will use that to wire up the API flow for custom command. The implementation of this custom command can be a NOP. * AMBARI-3731 will introduce some refactoring that will affect this patch. _We can work together to merge them._ This JIRA lays the base code to create custom action and a later JIRA will wire that up to the new ExecutionCommand format. > Changes to stacks definitions to allow custom services support (needed by an > ambari-agent) > ------------------------------------------------------------------------------------------ > > Key: AMBARI-3548 > URL: https://issues.apache.org/jira/browse/AMBARI-3548 > Project: Ambari > Issue Type: Bug > Components: controller > Affects Versions: 1.5.0 > Reporter: Dmitry Lysnichenko > Assignee: Dmitry Lysnichenko > Fix For: 1.5.0 > > Attachments: AMBARI-3548_preview.patch, hbase_new_metainfo.json, > hbase_new_metainfo.xml, hbase_old_metainfo.xml, new-style-command-dump.txt, > service_metainfo_changes.patch > > > Stack definitions for custom services should contain fields: > - service metadata > -- list of repositories > - component metadata should contain fields: > -- scriptType (possible values: "python", "puppet") > -- taskTimeout (per-component value) > Except metadata files, custom service directory should contain: > - script directory that contains separate python files for components (e.g. > namenode.py, datanode.py etc.) and service.py file. > - a separate directory for templates > Patch is so large because I've created a separate stack dir with modified > HBase metadata. -- This message was sent by Atlassian JIRA (v6.1#6144)