Thanks for the review.

The configuration is already under the <pluginManagement> section. Is that what 
you referred to as <managementPlugin> (maven doesn't have such an element)? 


  <build>
    <pluginManagement>
      <plugins>
        <plugin>
          <groupId>org.apache.maven.plugins</groupId>
          <artifactId>maven-javadoc-plugin</artifactId>
          <version>2.8</version>
        </plugin>

        <plugin>
          <groupId>org.apache.maven.plugins</groupId>
          <artifactId>maven-eclipse-plugin</artifactId>
          <version>2.8</version>
        </plugin>

        <plugin>
          <groupId>org.apache.maven.plugins</groupId>
          <artifactId>maven-war-plugin</artifactId>
          <version>2.2</version>
        </plugin>

Thanks,
Raymond

On Feb 13, 2012, at 1:06 PM, Simone Tripodi wrote:

> Hi! :)
> 
> I think that the war plugin should be placed in the
> <managementPlugin/> instead of <plugins>, WDYT?
> 
> -Simo
> 
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
> 
> 
> 
> On Mon, Feb 13, 2012 at 8:51 PM,  <[email protected]> wrote:
>> Author: rfeng
>> Date: Mon Feb 13 19:51:49 2012
>> New Revision: 1243669
>> 
>> URL: http://svn.apache.org/viewvc?rev=1243669&view=rev
>> Log:
>> Configure the maven eclipse and war plugin so that we can run "mvn 
>> eclipse:eclipse"
>> 
>> Modified:
>>    incubator/amber/trunk/pom.xml
>> 
>> Modified: incubator/amber/trunk/pom.xml
>> URL: 
>> http://svn.apache.org/viewvc/incubator/amber/trunk/pom.xml?rev=1243669&r1=1243668&r2=1243669&view=diff
>> ==============================================================================
>> --- incubator/amber/trunk/pom.xml (original)
>> +++ incubator/amber/trunk/pom.xml Mon Feb 13 19:51:49 2012
>> @@ -338,6 +338,18 @@
>>         </plugin>
>> 
>>         <plugin>
>> +          <groupId>org.apache.maven.plugins</groupId>
>> +          <artifactId>maven-eclipse-plugin</artifactId>
>> +          <version>2.8</version>
>> +        </plugin>
>> +
>> +        <plugin>
>> +          <groupId>org.apache.maven.plugins</groupId>
>> +          <artifactId>maven-war-plugin</artifactId>
>> +          <version>2.2</version>
>> +        </plugin>
>> +
>> +        <plugin>
>>           <artifactId>maven-clean-plugin</artifactId>
>>           <version>2.4.1</version>
>>         </plugin>
>> 
>> 

Reply via email to