Begin forwarded message:

From: Antonio Sanso <[email protected]<mailto:[email protected]>>
Date: February 14, 2012 10:01:21 AM GMT+01:00
To: "[email protected]<mailto:[email protected]>" 
<[email protected]<mailto:[email protected]>>
Subject: Re: svn commit: r1243684 - in /incubator/amber/trunk/oauth-2.0: 
oauth2-authzserver/src/test/java/org/apache/amber/oauth2/as/response/ 
oauth2-common/src/main/java/org/apache/amber/oauth2/common/ 
oauth2-common/src/main/java/org/apache/amber/oauth2/common...

Hi Lukasz, thanks a lot for tackling this.

Just a minor one. I am not really sure about this:

On Feb 13, 2012, at 9:46 PM, <[email protected]<mailto:[email protected]>> 
<[email protected]<mailto:[email protected]>> wrote:

-    public static final String OAUTH_TOKEN = "oauth_token";
+    public static final String OAUTH_TOKEN = "access_token";

Reason is this is used (containing the old value of oauth_token) in the patch 
you have committed for AMBER-28 [0] with the follow strategy:

" It will check the presence of "access_token" first and fall back to 
"oauth_token""

as for Raymond comment.

WDYT?

Regards

Antonio

[0] https://issues.apache.org/jira/browse/AMBER-28


Reply via email to