Re: [PATCH] drm/amdgpu: avoid reading vf2pf info size from FB

[Lazar, Lijo]

On 4/30/2024 7:53 PM, Zhigang Luo wrote:
> VF can't access FB when host is doing mode1 reset. Using sizeof to get
> vf2pf info size, instead of reading it from vf2pf header stored in FB.
> 
> Signed-off-by: Zhigang Luo <zhigang....@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> index 54ab51a4ada7..c84d2217005e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> @@ -583,7 +583,7 @@ static int amdgpu_virt_write_vf2pf_data(struct 
> amdgpu_device *adev)
>       }
>       vf2pf_info->checksum =
>               amd_sriov_msg_checksum(
> -             vf2pf_info, vf2pf_info->header.size, 0, 0);
> +             vf2pf_info, sizeof(struct amd_sriov_msg_vf2pf_info), 0, 0);

You may change to sizeof(*vf2pf_info).

Reviewed-by: Lijo Lazar <lijo.la...@amd.com>

Thanks,
Lijo

>  
>       return 0;
>  }