From: Alex Hung <alex.h...@amd.com>

This prevents accessing to negative index of link_encoders array.

This fixes an OVERRUN issue reported by Coverity.

Reviewed-by: Rodrigo Siqueira <rodrigo.sique...@amd.com>
Acked-by: Tom Chung <chiahsuan.ch...@amd.com>
Signed-off-by: Alex Hung <alex.h...@amd.com>
---
 drivers/gpu/drm/amd/display/dc/link/link_factory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/link/link_factory.c 
b/drivers/gpu/drm/amd/display/dc/link/link_factory.c
index cf22b8f28ba6..2c3f5d662285 100644
--- a/drivers/gpu/drm/amd/display/dc/link/link_factory.c
+++ b/drivers/gpu/drm/amd/display/dc/link/link_factory.c
@@ -390,7 +390,7 @@ static void link_destruct(struct dc_link *link)
                 * the dynamic assignment of link encoders to streams. Virtual 
links
                 * are not assigned encoder resources on creation.
                 */
-               if (link->link_id.id != CONNECTOR_ID_VIRTUAL) {
+               if (link->link_id.id != CONNECTOR_ID_VIRTUAL && link->eng_id != 
ENGINE_ID_UNKNOWN) {
                        link->dc->res_pool->link_encoders[link->eng_id - 
ENGINE_ID_DIGA] = NULL;
                        link->dc->res_pool->dig_link_enc_count--;
                }
-- 
2.34.1

Reply via email to