[AMD Official Use Only - AMD Internal Distribution Only]
Hi Thomas,
Sure, will do, thanks.
Regards,
Liu, Xiang
________________________________
From: Chai, Thomas <yipeng.c...@amd.com>
Sent: Wednesday, August 20, 2025 9:39 AM
To: Liu, Xiang(Dean) <xiang....@amd.com>; amd-gfx@lists.freedesktop.org
<amd-gfx@lists.freedesktop.org>
Cc: Zhang, Hawking <hawking.zh...@amd.com>; Zhou1, Tao <tao.zh...@amd.com>;
Yang, Stanley <stanley.y...@amd.com>
Subject: RE: [PATCH 2/2] drm/amdgpu: Check VF critical region before RAS poison
injection
[AMD Official Use Only - AMD Internal Distribution Only]
-----Original Message-----
From: Liu, Xiang(Dean) <xiang....@amd.com>
Sent: Tuesday, August 19, 2025 1:26 PM
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking <hawking.zh...@amd.com>; Zhou1, Tao <tao.zh...@amd.com>;
Yang, Stanley <stanley.y...@amd.com>; Chai, Thomas <yipeng.c...@amd.com>; Liu,
Xiang(Dean) <xiang....@amd.com>
Subject: [PATCH 2/2] drm/amdgpu: Check VF critical region before RAS poison
injection
Check VF critical region before RAS poison injection to ensure that the poison
injection will not hit the VF critical region.
Signed-off-by: Xiang Liu <xiang....@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
index b00cbb927ca8..6730de574fdc 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
@@ -219,10 +219,17 @@ static int amdgpu_check_address_validity(struct
amdgpu_device *adev,
struct amdgpu_vram_block_info blk_info;
uint64_t page_pfns[32] = {0};
int i, ret, count;
+ bool hit = false;
if (amdgpu_ip_version(adev, UMC_HWIP, 0) < IP_VERSION(12, 0, 0))
return 0;
+ if (amdgpu_sriov_vf(adev)) {
+ if (amdgpu_virt_check_vf_critical_region(adev, address, &hit))
+ return -EPERM;
+ return hit ? -EACCES : 0;
[Thomas]Only checking if the address is within the PF critical address regions
may be not sufficient,
The VF critical address regions of guest may be also need to be
checked.
+ }
+
if ((address >= adev->gmc.mc_vram_size) ||
(address >= RAS_UMC_INJECT_ADDR_LIMIT))
return -EFAULT;
--
2.34.1
