On 08/04/2016 12:44 PM, zhoucm1 wrote: > > On 2016年08月03日 20:16, Edward O'Callaghan wrote: >> Hi, >> >> I didn't see any of my previous review remarks on your previous >> submission addresses in this submission of this series? > Hi Edward, > > Sorry for that. Since these patch sets are big feature change and we > need to pin down the approach of the solution first. As you see, > Christian has argued this solution and suggested another direction. > When we change the direction, the patches could be different totally. So > I didn't address patch itself flaw. But indeed many thanks for your review. No problem, welcome to the community and thanks for your hard work! :)
> > Thanks, > David Zhou > >> >> Kind Regards, >> Edward. >> >> On 08/02/2016 05:51 PM, Chunming Zhou wrote: >>> every vm has itself recovery entity, which is used to reovery page table >>> from their shadow. >>> They don't need to wait front vm completed. >>> And also using all pte rings can speed reovery. >>> >>> every scheduler has its own recovery entity, which is used to save hw jobs, >>> and resubmit from it, which solves the conflicts between reset thread and >>> scheduler thread when run job. >>> >>> And some fixes when doing this improment. >>> >>> Chunming Zhou (11): >>> drm/amdgpu: hw ring should be empty when gpu reset >>> drm/amdgpu: specify entity to amdgpu_copy_buffer >>> drm/amd: add recover run queue for scheduler >>> drm/amdgpu: fix vm init error path >>> drm/amdgpu: add vm recover entity >>> drm/amdgpu: use all pte rings to recover page table >>> drm/amd: add recover entity for every scheduler >>> drm/amd: use scheduler to recover hw jobs >>> drm/amd: hw job list should be exact >>> drm/amd: reset jobs to recover entity >>> drm/amdgpu: no need fence wait every time >>> >>> drivers/gpu/drm/amd/amdgpu/amdgpu.h | 5 +- >>> drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c | 3 +- >>> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 35 +++++-- >>> drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 11 +++ >>> drivers/gpu/drm/amd/amdgpu/amdgpu_test.c | 8 +- >>> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 5 +- >>> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 27 ++++-- >>> drivers/gpu/drm/amd/scheduler/gpu_scheduler.c | 129 >>> +++++++++++++------------- >>> drivers/gpu/drm/amd/scheduler/gpu_scheduler.h | 4 +- >>> 9 files changed, 135 insertions(+), 92 deletions(-) >>> >> >> >> _______________________________________________ >> amd-gfx mailing list >> amd-gfx@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx >
signature.asc
Description: OpenPGP digital signature
_______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx