For patch #4:
drm/amdgpu: remove useless functions of si dpm
Maybe call that "remove unused function forward define".
And in general patches should at least have a commit message and not
just subject. A simple one liner like "The functions don't exists any
more." should be sufficient in this case.
Patch #10:
Well we probably shouldn't call those functions rv770_* any more.
Apart from that the patches look good to me, but since I'm clearly not
the DPM expert they are Acked-by: Christian König
<[email protected]>.
Regards,
Christian.
Am 30.08.2016 um 13:49 schrieb Huang Rui:
Hi all,
These patchest resolve the DPM issues of SI.
SI DPM doesn't work since it implemented, the following patches fixes
serival issues to make SI DPM workable now.
Patch 1 -> 3: Add firmware version for checking firmware loading via
sysfs.
Patch 4 -> 5: Refine the codes for si dpm.
Patch 6 -> 13: Fix the issues which impact DPM functionality.
Patch 14: Enable SI DPM by default.
Thanks,
Rui
Huang Rui (14):
drm/amdgpu: add gfx v6 firmware versions for sysfs dump
drm/amdgpu: add gmc v6 firmware versions for sysfs dump
drm/amdgpu/si: add SI smc firmware versions for sysfs dump
drm/amdgpu: remove useless functions of si dpm
drm/amdgpu: use DRM print instead of printk
drm/amdgpu: fix oland and hainan asic specific handle at
si_program_aspm
drm/amdgpu/si: fix the dce6 for si macro
drm/amdgpu: fix the tahiti specific value of DEEP_SLEEP_CLK_SEL field
drm/amdgpu: fix to miss adding thermal controller
drm/amdgpu: add rv770_get_memory_type to set the GDDR5 flag
drm/amdgpu: fix incorrect index of CG_FFCT_0 register
drm/amdgpu: introduce pcie port read/write entry
drm/amdgpu: fix incorrect reading method at si_get_current_pcie_speed
drm/amdgpu/si: enable SI DPM by default
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 +
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +
drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 14 ++++
drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 2 +
drivers/gpu/drm/amd/amdgpu/si.c | 112 ++++++++++++++------------
drivers/gpu/drm/amd/amdgpu/si_dpm.c | 54 +++++++++----
drivers/gpu/drm/amd/amdgpu/si_smc.c | 1 +
drivers/gpu/drm/amd/include/asic_reg/si/sid.h | 6 +-
8 files changed, 124 insertions(+), 71 deletions(-)
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
