We can make it dGpu specific if APU has no problem.

Regards,
David Zhou

On 2016年10月10日 15:09, Christian König wrote:
i'm a trailblazer of bad ideas at times :-) hehehehe
Well, I know this because I had the same bad idea earlier and spend a lot of time bisecting why it broke :)

Christian.

Am 09.10.2016 um 19:54 schrieb Tom St Denis:
Yup that's what I said in another part of the thread :-)

i'm a trailblazer of bad ideas at times :-) hehehehe

Tom

On Sun, Oct 9, 2016 at 11:13 AM Christian König <[email protected] <mailto:[email protected]>> wrote:

    Am 05.10.2016 um 21:42 schrieb Alex Deucher:
    > Looks like fallout from a rebase or merge.
    >
    > Signed-off-by: Alex Deucher <[email protected]
    <mailto:[email protected]>>

    NAK, this is done on purpose and is for evicting the GART table using
    memcpy.

    Tom wanted to remove that as well and it makes resume then fail
    horrible
    on dGPUs.

    We should probably add a comment why this is necessary.

    Christian.

    > ---
    >   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ---
    >   1 file changed, 3 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
    b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
    > index 45259b5..c2f70be 100644
    > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
    > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
    > @@ -1956,9 +1956,6 @@ int amdgpu_device_suspend(struct
    drm_device *dev, bool suspend, bool fbcon)
    >
    >       r = amdgpu_suspend(adev);
    >
    > -     /* evict remaining vram memory */
    > -     amdgpu_bo_evict_vram(adev);
    > -
    >       pci_save_state(dev->pdev);
    >       if (suspend) {
    >               /* Shut down the device */


    _______________________________________________
    amd-gfx mailing list
    [email protected] <mailto:[email protected]>
    https://lists.freedesktop.org/mailman/listinfo/amd-gfx




_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to