Hi Alex,

> We can use amdgpu_dpm_get_sclk() and amdgpu_dpm_get_mclk() for both powerplay 
> and non-powerplay.  No need to special case it.
Tested. It seems so. Updated the patch accordingly. Please have a check.

Regards,
Evan

-----Original Message-----
From: Alex Deucher [mailto:alexdeuc...@gmail.com] 
Sent: Friday, October 14, 2016 5:52 AM
To: Quan, Evan <evan.q...@amd.com>
Cc: Deucher, Alexander <alexander.deuc...@amd.com>; 
amd-gfx@lists.freedesktop.org; Zhang, Jerry <jerry.zh...@amd.com>; Huan, Alvin 
<alvin.h...@amd.com>; Huang, Ray <ray.hu...@amd.com>
Subject: Re: drm/amd/powerplay: expose max engine and memory clock info for 
powerplay enabled case

On Thu, Oct 13, 2016 at 4:24 AM, Quan, Evan <evan.q...@amd.com> wrote:
> Hi Alex,
>
>
>
> Thanks for your information.
>
> I updated the patch using the amdgpu_dpm_get_sclk/mclk APIs which make 
> the patch much simpler.
>
>

We can use amdgpu_dpm_get_sclk() and amdgpu_dpm_get_mclk() for both powerplay 
and non-powerplay.  No need to special case it.

Alex

>
> Regards,
>
> Evan
>
>
>
> From: Deucher, Alexander
> Sent: Thursday, October 13, 2016 6:04 AM
> To: Quan, Evan <evan.q...@amd.com>; amd-gfx@lists.freedesktop.org
> Cc: Zhang, Jerry <jerry.zh...@amd.com>; Huan, Alvin 
> <alvin.h...@amd.com>; Quan, Evan <evan.q...@amd.com>; Huang, Ray 
> <ray.hu...@amd.com>
> Subject: RE: drm/amd/powerplay: expose max engine and memory clock 
> info for powerplay enabled case
>
>
>
> I don't know if we need to add a cgs call to fill in the 
> max_clock_voltage_limits structure.  That's mostly just leftover from 
> radeon.  A better solution would be use the existing 
> amdgpu_dpm_get_sclk and amdgpu_dpm_get_mclk macros.  Maybe something 
> like the attached patch? Unless there is a specific need for the max 
> clocks on AC.  I think in most cases the results will be the same.
>
>
>
> Alex
>
>
>
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf 
> Of Quan, Evan
> Sent: Wednesday, October 12, 2016 1:53 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Zhang, Jerry; Huan, Alvin; Quan, Evan; Huang, Ray
> Subject: drm/amd/powerplay: expose max engine and memory clock info 
> for powerplay enabled case
>
>
>
> Hi All,
>
>
>
> We found the max engine clock and max memory clock are both wrongly 
> reported as 0(by AMDGPU_INFO_DEV_INFO ioctl).
>
> The attached patch tries to fix it.
>
> Please help to review it.
>
> Any comment is welcomed.
>
>
>
> Regards,
>
> Evan
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>

Attachment: 0001-drm-amd-amdgpu-expose-max-engine-and-memory-clock-fo.patch
Description: 0001-drm-amd-amdgpu-expose-max-engine-and-memory-clock-fo.patch

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to