This patch is Reviewed-by: Rex Zhu <rex....@amd.com>

Best Regards
Rex
-----Original Message-----
From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of 
Xiangliang Yu
Sent: Wednesday, November 30, 2016 3:03 PM
To: amd-gfx@lists.freedesktop.org
Cc: Yu, Xiangliang
Subject: [PATCH 6/6] drm/amd/powerplay: Fix potential NULL pointer issue

If doesn't enable dpm, the powerplay will not allocate memory for hw 
management. So, hw_init_power_state_table function will reference NULL pointer 
when resetting.

Signed-off-by: Xiangliang Yu <xiangliang...@amd.com>
---
 drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c 
b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
index 51a3607..c81cf14 100644
--- a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
+++ b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
@@ -1004,12 +1004,12 @@ int amd_powerplay_reset(void *handle)
        if (ret)
                return ret;
 
-       hw_init_power_state_table(instance->hwmgr);
-
        if ((amdgpu_dpm == 0)
                || cgs_is_virtualization_enabled(instance->smu_mgr->device))
                return 0;
 
+       hw_init_power_state_table(instance->hwmgr);
+
        if (eventmgr == NULL || eventmgr->pp_eventmgr_init == NULL)
                return -EINVAL;
 
--
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to