From: Hersen Wu <[email protected]>

Change-Id: Ia19bcb874b7ae22201f2b7cfef3c42c10276c6d5
Signed-off-by: Hersen Wu <[email protected]>
Reviewed-by: Hersen Wu <[email protected]>
Acked-by: Harry Wentland <[email protected]>
---
 drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 7 ++++---
 drivers/gpu/drm/amd/display/dc/core/dc.c           | 3 +--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c 
b/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
index 682fc9b9b3f2..fcd3b72287c8 100644
--- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
+++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
@@ -410,6 +410,9 @@ enum generic_id generic_id_from_bios_object_id(uint32_t 
bios_object_id)
        return id;
 }
 
+/* BIOS oject table displaypath is per connector.
+ * There is extra path not for connector. BIOS fill its encoderid as 0
+ */
 static uint8_t bios_parser_get_connectors_number(struct dc_bios *dcb)
 {
        struct bios_parser *bp = BP_FROM_DCB(dcb);
@@ -417,9 +420,7 @@ static uint8_t bios_parser_get_connectors_number(struct 
dc_bios *dcb)
        unsigned int i;
 
        for (i = 0; i < bp->object_info_tbl.v1_4->number_of_path; i++) {
-               if (bp->object_info_tbl.v1_4->display_path[i].encoderobjid != 0
-                               &&
-               bp->object_info_tbl.v1_4->display_path[i].display_objid != 0)
+               if (bp->object_info_tbl.v1_4->display_path[i].encoderobjid != 0)
                        count++;
        }
        return count;
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c 
b/drivers/gpu/drm/amd/display/dc/core/dc.c
index c33e31c9e3e1..323a5e706908 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
@@ -97,6 +97,7 @@ static bool create_links(
                struct core_link *link;
 
                link_init_params.ctx = dc->ctx;
+               /* next BIOS object table connector */
                link_init_params.connector_index = i;
                link_init_params.link_index = dc->link_count;
                link_init_params.dc = dc;
@@ -106,8 +107,6 @@ static bool create_links(
                        dc->links[dc->link_count] = link;
                        link->dc = dc;
                        ++dc->link_count;
-               } else {
-                       dm_error("DC: failed to create link!\n");
                }
        }
 
-- 
2.11.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to