[AMD Official Use Only - General] Reviewed-by: Tao Zhou <[email protected]>
> -----Original Message----- > From: amd-gfx <[email protected]> On Behalf Of Srinivasan > Shanmugam > Sent: Wednesday, December 20, 2023 10:40 PM > To: Deucher, Alexander <[email protected]>; Koenig, Christian > <[email protected]> > Cc: SHANMUGAM, SRINIVASAN <[email protected]>; amd- > [email protected] > Subject: [PATCH] drm/amdgpu: Drop redundant unsigned >=0 comparision > 'amdgpu_gfx_rlc_init_microcode()' > > unsigned int "version_minor" is always >= 0 > > Fixes the below: > drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c:534 > amdgpu_gfx_rlc_init_microcode() warn: always true condition '(version_minor >= > 0) => (0-u16max >= 0)' > > Cc: Christian König <[email protected]> > Cc: Alex Deucher <[email protected]> > Signed-off-by: Srinivasan Shanmugam <[email protected]> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c > index 35e0ae9acadc..2c3675d91614 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c > @@ -531,13 +531,12 @@ int amdgpu_gfx_rlc_init_microcode(struct > amdgpu_device *adev, > if (version_major == 2 && version_minor == 1) > adev->gfx.rlc.is_rlc_v2_1 = true; > > - if (version_minor >= 0) { > - err = amdgpu_gfx_rlc_init_microcode_v2_0(adev); > - if (err) { > - dev_err(adev->dev, "fail to init rlc v2_0 microcode\n"); > - return err; > - } > + err = amdgpu_gfx_rlc_init_microcode_v2_0(adev); > + if (err) { > + dev_err(adev->dev, "fail to init rlc v2_0 microcode\n"); > + return err; > } > + > if (version_minor >= 1) > amdgpu_gfx_rlc_init_microcode_v2_1(adev); > if (version_minor >= 2) > -- > 2.34.1
<<attachment: winmail.dat>>
