Re: [PATCH v2] drm/amdgpu/mes: fix use-after-free issue

[Christian König]

Am 22.04.24 um 13:12 schrieb Lazar, Lijo:

On 4/22/2024 3:09 PM, Jack Xiao wrote:

Delete fence fallback timer to fix the ramdom
use-after-free issue.

v2: move to amdgpu_mes.c

Signed-off-by: Jack Xiao <jack.x...@amd.com>

Acked-by: Lijo Lazar <lijo.la...@amd.com>

Acked-by: Christian König <christian.koe...@amd.com>

Thanks,
Lijo

---
  drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
index 78e4f88f5134..226751ea084b 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
@@ -1128,6 +1128,7 @@ void amdgpu_mes_remove_ring(struct amdgpu_device *adev,
                return;

amdgpu_mes_remove_hw_queue(adev, ring->hw_queue_id);

+       del_timer_sync(&ring->fence_drv.fallback_timer);
        amdgpu_ring_fini(ring);
        kfree(ring);
  }