[AMD Official Use Only - General] Reviewed-by: Aurabindo Pillai <aurabindo.pil...@amd.com>
-- Regards, Jay ________________________________ From: SHANMUGAM, SRINIVASAN <srinivasan.shanmu...@amd.com> Sent: Tuesday, April 23, 2024 9:34 PM To: Siqueira, Rodrigo <rodrigo.sique...@amd.com>; Pillai, Aurabindo <aurabindo.pil...@amd.com> Cc: amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; SHANMUGAM, SRINIVASAN <srinivasan.shanmu...@amd.com>; Liu, Wenjing <wenjing....@amd.com>; Chung, ChiaHsuan (Tom) <chiahsuan.ch...@amd.com>; Lee, Alvin <alvin.l...@amd.com>; Li, Roman <roman...@amd.com>; Wu, Hersen <hersenxs...@amd.com>; Hung, Alex <alex.h...@amd.com>; Wentland, Harry <harry.wentl...@amd.com>; Dan Carpenter <dan.carpen...@linaro.org> Subject: [PATCH v2] drm/amd/display: Remove redundant NULL check in dcn10_set_input_transfer_func This commit removes an unnecessary NULL check in the `dcn10_set_input_transfer_func` function in the `dcn10_hwseq.c` file. The variable `tf` is assigned the address of `plane_state->in_transfer_func` unconditionally, so it can never be `NULL`. Therefore, the check `if (tf == NULL)` is unnecessary and has been removed. Fixes the below smatch warning: drivers/gpu/drm/amd/amdgpu/../display/dc/hwss/dcn10/dcn10_hwseq.c:1839 dcn10_set_input_transfer_func() warn: address of 'plane_state->in_transfer_func' is non-NULL Fixes: 285a7054bf81 ("drm/amd/display: Remove plane and stream pointers from dc scratch") Cc: Wenjing Liu <wenjing....@amd.com> Cc: Tom Chung <chiahsuan.ch...@amd.com> Cc: Alvin Lee <alvin.l...@amd.com> Cc: Rodrigo Siqueira <rodrigo.sique...@amd.com> Cc: Roman Li <roman...@amd.com> Cc: Hersen Wu <hersenxs...@amd.com> Cc: Alex Hung <alex.h...@amd.com> Cc: Aurabindo Pillai <aurabindo.pil...@amd.com> Cc: Harry Wentland <harry.wentl...@amd.com> Suggested-by: Dan Carpenter <dan.carpen...@linaro.org> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmu...@amd.com> --- v2: - s/dcn20/dcn10 in commit title drivers/gpu/drm/amd/display/dc/hwss/dcn10/dcn10_hwseq.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn10/dcn10_hwseq.c b/drivers/gpu/drm/amd/display/dc/hwss/dcn10/dcn10_hwseq.c index 32a07ab74c51..f258914a4838 100644 --- a/drivers/gpu/drm/amd/display/dc/hwss/dcn10/dcn10_hwseq.c +++ b/drivers/gpu/drm/amd/display/dc/hwss/dcn10/dcn10_hwseq.c @@ -1837,9 +1837,7 @@ bool dcn10_set_input_transfer_func(struct dc *dc, struct pipe_ctx *pipe_ctx, && dce_use_lut(plane_state->format)) dpp_base->funcs->dpp_program_input_lut(dpp_base, &plane_state->gamma_correction); - if (tf == NULL) - dpp_base->funcs->dpp_set_degamma(dpp_base, IPP_DEGAMMA_MODE_BYPASS); - else if (tf->type == TF_TYPE_PREDEFINED) { + if (tf->type == TF_TYPE_PREDEFINED) { switch (tf->tf) { case TRANSFER_FUNCTION_SRGB: dpp_base->funcs->dpp_set_degamma(dpp_base, IPP_DEGAMMA_MODE_HW_sRGB); -- 2.34.1