Re: [PATCH 6/8] drm/amdkfd: remove dead code in the function svm_range_get_pte_flags

[Felix Kuehling]

On 2024-05-29 23:49, Jesse Zhang wrote:

The varible uncached  set false, the condition uncached cannot be true.
So remove the dead code, mapping flags will set the flag AMDGPU_VM_MTYPE_UC in 
else.

Signed-off-by: Jesse Zhang <jesse.zh...@amd.com>

Reviewed-by: Felix Kuehling <felix.kuehl...@amd.com>

---
  drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 5 +----
  1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c 
b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
index 407636a68814..bd9c2921e0dc 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
@@ -1171,7 +1171,6 @@ svm_range_get_pte_flags(struct kfd_node *node,
        bool snoop = (domain != SVM_RANGE_VRAM_DOMAIN);
        bool coherent = flags & (KFD_IOCTL_SVM_FLAG_COHERENT | 
KFD_IOCTL_SVM_FLAG_EXT_COHERENT);
        bool ext_coherent = flags & KFD_IOCTL_SVM_FLAG_EXT_COHERENT;
-       bool uncached = false; /*flags & KFD_IOCTL_SVM_FLAG_UNCACHED;*/
        unsigned int mtype_local;

if (domain == SVM_RANGE_VRAM_DOMAIN)

@@ -1220,9 +1219,7 @@ svm_range_get_pte_flags(struct kfd_node *node,
                        mtype_local = amdgpu_mtype_local == 1 ? 
AMDGPU_VM_MTYPE_NC :
                                amdgpu_mtype_local == 2 ? AMDGPU_VM_MTYPE_CC : 
AMDGPU_VM_MTYPE_RW;
                snoop = true;
-               if (uncached) {
-                       mapping_flags |= AMDGPU_VM_MTYPE_UC;
-               } else if (domain == SVM_RANGE_VRAM_DOMAIN) {
+               if (domain == SVM_RANGE_VRAM_DOMAIN) {
                        /* local HBM region close to partition */
                        if (bo_node->adev == node->adev &&
                            (!bo_node->xcp || !node->xcp || bo_node->xcp->mem_id == 
node->xcp->mem_id))