Re: [PATCH 29/50] drm/amd/display: Re-enable panel replay feature

[Leo Li]

On 2024-07-10 15:36, Fangzhi Zuo wrote:
From: Tom Chung <chiahsuan.ch...@amd.com>

[Why & How]
Fixed the replay issues and now re-enable the panel replay feature.

Reported-by: Arthur Borsboom <arthurborsb...@gmail.com>
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3344

Reviewed-by: Mario Limonciello <mario.limoncie...@amd.com>
Reviewed-by: Rodrigo Siqueira <rodrigo.sique...@amd.com>
Signed-off-by: Jerry Zuo <jerry....@amd.com>
Signed-off-by: Tom Chung <chiahsuan.ch...@amd.com>

Hi Jerry,

Please drop this patch as there's a known PSR SU regression caused by a patch 
that originally fixed the aforementioned replay issue.

Thanks,
Leo

---
  .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 20 ++++++++-----------
  1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c 
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index fe5a96e5c70a..864a66406f8a 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -4836,18 +4836,14 @@ static int amdgpu_dm_initialize_drm_device(struct 
amdgpu_device *adev)
        /* Determine whether to enable Replay support by default. */
        if (!(amdgpu_dc_debug_mask & DC_DISABLE_REPLAY)) {
                switch (amdgpu_ip_version(adev, DCE_HWIP, 0)) {
-/*
- * Disabled by default due to 
https://gitlab.freedesktop.org/drm/amd/-/issues/3344
- *             case IP_VERSION(3, 1, 4):
- *             case IP_VERSION(3, 1, 5):
- *             case IP_VERSION(3, 1, 6):
- *             case IP_VERSION(3, 2, 0):
- *             case IP_VERSION(3, 2, 1):
- *             case IP_VERSION(3, 5, 0):
- *             case IP_VERSION(3, 5, 1):
- *                     replay_feature_enabled = true;
- *                     break;
- */
+               case IP_VERSION(3, 1, 4):
+               case IP_VERSION(3, 2, 0):
+               case IP_VERSION(3, 2, 1):
+               case IP_VERSION(3, 5, 0):
+               case IP_VERSION(3, 5, 1):
+                       replay_feature_enabled = true;
+                       break;
+
                default:
                        replay_feature_enabled = amdgpu_dc_feature_mask & 
DC_REPLAY_MASK;
                        break;