Re: [PATCH] drm/amdgpu: clean up vbios fetching code

[Lazar, Lijo]

On 9/17/2024 6:24 PM, Alex Deucher wrote:
> After splitting the logic between APU and dGPU,
> clean up some of the APU and dGPU specific logic
> that no longer applied.
> 
> Signed-off-by: Alex Deucher <alexander.deuc...@amd.com>

Reviewed-by: Lijo Lazar <lijo.la...@amd.com>

Thanks,
Lijo

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 16 ++--------------
>  1 file changed, 2 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
> index e8f62d718167b..46bf623919d7c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
> @@ -284,10 +284,6 @@ static bool amdgpu_atrm_get_bios(struct amdgpu_device 
> *adev)
>       acpi_status status;
>       bool found = false;
>  
> -     /* ATRM is for the discrete card only */
> -     if (adev->flags & AMD_IS_APU)
> -             return false;
> -
>       /* ATRM is for on-platform devices only */
>       if (dev_is_removable(&adev->pdev->dev))
>               return false;
> @@ -343,11 +339,8 @@ static inline bool amdgpu_atrm_get_bios(struct 
> amdgpu_device *adev)
>  
>  static bool amdgpu_read_disabled_bios(struct amdgpu_device *adev)
>  {
> -     if (adev->flags & AMD_IS_APU)
> -             return igp_read_bios_from_vram(adev);
> -     else
> -             return (!adev->asic_funcs || 
> !adev->asic_funcs->read_disabled_bios) ?
> -                     false : amdgpu_asic_read_disabled_bios(adev);
> +     return (!adev->asic_funcs || !adev->asic_funcs->read_disabled_bios) ?
> +             false : amdgpu_asic_read_disabled_bios(adev);
>  }
>  
>  #ifdef CONFIG_ACPI
> @@ -455,11 +448,6 @@ static bool amdgpu_get_bios_dgpu(struct amdgpu_device 
> *adev)
>               goto success;
>       }
>  
> -     if (igp_read_bios_from_vram(adev)) {
> -             dev_info(adev->dev, "Fetched VBIOS from VRAM BAR\n");
> -             goto success;
> -     }
> -
>       if (amdgpu_read_platform_bios(adev)) {
>               dev_info(adev->dev, "Fetched VBIOS from platform\n");
>               goto success;