On 2025-01-15 02:56, Simon Ser wrote: > Is this "ignore" something we could do at the core DRM level, instead > of doing it in all drivers? e.g. by silently ignoring user-space requests > to set the property? > I think it'd be better to reject setting the property. The problem is that a client without the COLOR_PIPELINE client cap might have set these properties and we'll want to ignore that when we are programming a commit with a color pipeline. Since it's the drivers that decide on the programming based on the states it's up to each driver to ignore the deprecated properties. > It sounds like this codepath still resets the colorspace to sRGB, which > is later overwritten by colorops pulled in the atomic state anyways. We didn't yet define a colorop for COLOR_RANGE and COLOR_ENCODING so the color pipeline currently only supports RGB content. The intention is to set a reasonable default but the HW programming code should be ignoring this for RGB content. Harry
- [V7 14/45] drm/vkms: Add enumerated 1D curve colorop Alex Hung
- [V7 16/45] drm/colorop: Add 3x4 CTM type Alex Hung
- [V7 17/45] drm/vkms: Use s32 for internal color pipeline pr... Alex Hung
- [V7 18/45] drm/vkms: add 3x4 matrix in color pipeline Alex Hung
- [V7 19/45] drm/tests: Add a few tests around drm_fixed.h Alex Hung
- [V7 20/45] drm/vkms: Add tests for CTM handling Alex Hung
- [V7 21/45] drm/colorop: pass plane_color_pipeline client ca... Alex Hung
- [V7 23/45] drm/amd/display: Ignore deprecated props when pl... Alex Hung
- Re: [V7 23/45] drm/amd/display: Ignore deprecated prop... Simon Ser
- Re: [V7 23/45] drm/amd/display: Ignore deprecated ... Harry Wentland
- [V7 25/45] drm/amd/display: Skip color pipeline initializat... Alex Hung
- [V7 26/45] drm/amd/display: Add support for sRGB EOTF in DE... Alex Hung
- [V7 27/45] drm/amd/display: Add support for sRGB Inverse EO... Alex Hung
- [V7 28/45] drm/amd/display: Add support for sRGB EOTF in BL... Alex Hung
- [V7 29/45] drm/colorop: Add PQ 125 EOTF and its inverse Alex Hung
