[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Kenneth Feng [email protected]
-----Original Message----- From: amd-gfx <[email protected]> On Behalf Of Alex Deucher Sent: Monday, February 3, 2025 11:41 PM To: [email protected] Cc: Deucher, Alexander <[email protected]> Subject: [PATCH] drm/amdgpu/sdma4: drop gfxoff calls in dump ip state Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. SDMA 4.x is not part of the GFX power domain so this is not necessary. Signed-off-by: Alex Deucher <[email protected]> --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c index b48d9c0b2e1c3..ea42fb10d2076 100644 --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c @@ -2381,7 +2381,6 @@ static void sdma_v4_0_dump_ip_state(struct amdgpu_ip_block *ip_block) if (!adev->sdma.ip_dump) return; - amdgpu_gfx_off_ctrl(adev, false); for (i = 0; i < adev->sdma.num_instances; i++) { instance_offset = i * reg_count; for (j = 0; j < reg_count; j++) @@ -2389,7 +2388,6 @@ static void sdma_v4_0_dump_ip_state(struct amdgpu_ip_block *ip_block) RREG32(sdma_v4_0_get_reg_offset(adev, i, sdma_reg_list_4_0[j].reg_offset)); } - amdgpu_gfx_off_ctrl(adev, true); } const struct amd_ip_funcs sdma_v4_0_ip_funcs = { -- 2.48.1
