Re: [PATCH] drm/amdgpu: disable BAR resize on Dell G5 SE

[Lazar, Lijo]

On 2/19/2025 9:58 PM, Alex Deucher wrote:
> There was a quirk added to add a workaround for a Sapphire
> RX 5600 XT Pulse that didn't allow BAR resizing.  However,
> the quirk caused a regression with runtim pm on Dell laptops
> using those chips, rather than narrowing the scope of the
> resizing quirk, add a quirk to prevent amdgpu from resizing
> the BAR on those Dell platforms unless runtime pm is disabled.
> 
> v2: update commit message, add runpm check
> 
> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/1707
> Fixes: 907830b0fc9e ("PCI: Add a REBAR size quirk for Sapphire RX 5600 XT 
> Pulse")
> Signed-off-by: Alex Deucher <alexander.deuc...@amd.com>

Reviewed-by: Lijo Lazar <lijo.la...@amd.com>

Thanks,
Lijo

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 5ec71f146fa93..cae6dcb95a131 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1662,6 +1662,13 @@ int amdgpu_device_resize_fb_bar(struct amdgpu_device 
> *adev)
>       if (amdgpu_sriov_vf(adev))
>               return 0;
>  
> +     /* resizing on Dell G5 SE platforms causes problems with runtime pm */
> +     if ((amdgpu_runtime_pm != 0) &&
> +         adev->pdev->vendor == PCI_VENDOR_ID_ATI &&
> +         adev->pdev->device == 0x731f &&
> +         adev->pdev->subsystem_vendor == PCI_VENDOR_ID_DELL)
> +             return 0;
> +
>       /* PCI_EXT_CAP_ID_VNDR extended capability is located at 0x100 */
>       if (!pci_find_ext_capability(adev->pdev, PCI_EXT_CAP_ID_VNDR))
>               DRM_WARN("System can't access extended configuration space, 
> please check!!\n");