[Public]
>-----Original Message-----
>From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> On Behalf Of Alex Deucher
>Sent: Friday, June 27, 2025 10:34 PM
>To: amd-gfx@lists.freedesktop.org
>Cc: Deucher, Alexander <alexander.deuc...@amd.com>
>Subject: [PATCH 5/6] drm/amdgpu: add support for cyan skillfish gpu_info
>
>Some SOCs which are part of the cyan skillfish family rely on an explicit
>firmware for
>IP discovery. Add support for the gpu_info firmware.
>
>Signed-off-by: Alex Deucher <alexander.deuc...@amd.com>
>---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>index d1b122090b3d8..758e51505b3c7 100644
>--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>@@ -95,6 +95,7 @@ MODULE_FIRMWARE("amdgpu/picasso_gpu_info.bin");
> MODULE_FIRMWARE("amdgpu/raven2_gpu_info.bin");
> MODULE_FIRMWARE("amdgpu/arcturus_gpu_info.bin");
> MODULE_FIRMWARE("amdgpu/navi12_gpu_info.bin");
>+MODULE_FIRMWARE("amdgpu/cyan_skillfish1_gpu_info.bin");
>
> #define AMDGPU_RESUME_MS 2000
> #define AMDGPU_MAX_RETRY_LIMIT 2
>@@ -2603,6 +2604,9 @@ static int amdgpu_device_parse_gpu_info_fw(struct
>amdgpu_device *adev)
> case CHIP_NAVI12:
> chip_name = "navi12";
> break;
>+ case CHIP_CYAN_SKILLFISH:
>+ chip_name = "cyan_skillfish1";
>+ break;
> }
It would be better to name it "cyan_skillfish" which follows the name
convention.
E.g., raven/raven2, phoenix/phoenix2, cyan_skillfish/cyan_skillfish2.
Do you need to parse its name in amdgpu_ucode_legacy_naming()?
Regards,
Lang
>
> err = amdgpu_ucode_request(adev, &adev->firmware.gpu_info_fw,
>--
>2.50.0
