Re: [PATCH] drm/amd/pm: fix null pointer access

[Alex Deucher]

On Sat, Jul 12, 2025 at 10:13 AM Umio Yasuno
<coelacanth_dr...@protonmail.com> wrote:
>
> Writing a string without delimiters (' ', '\n', '\0') to the under
> gpu_od/fan_ctrl sysfs or pp_power_profile_mode for the CUSTOM profile
> will result in a null pointer dereference.
>
> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4401

Please add your signed-off-by.  With that, the patch is:
Acked-by: Alex Deucher <alexander.deuc...@amd.com>

Alex

> ---
>  drivers/gpu/drm/amd/pm/amdgpu_pm.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c 
> b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> index edd9895b4..39ee81085 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> @@ -1398,6 +1398,8 @@ static ssize_t amdgpu_set_pp_power_profile_mode(struct 
> device *dev,
>                         if (ret)
>                                 return -EINVAL;
>                         parameter_size++;
> +                       if (!tmp_str)
> +                               break;
>                         while (isspace(*tmp_str))
>                                 tmp_str++;
>                 }
> @@ -3645,6 +3647,9 @@ static int parse_input_od_command_lines(const char *buf,
>                         return -EINVAL;
>                 parameter_size++;
>
> +               if (!tmp_str)
> +                       break;
> +
>                 while (isspace(*tmp_str))
>                         tmp_str++;
>         }
> --
> 2.47.2
>
>