[AMD Official Use Only - AMD Internal Distribution Only] -----Original Message----- From: Lazar, Lijo <lijo.la...@amd.com> Sent: Thursday, August 21, 2025 11:45 PM To: Zhang, Jesse(Jie) <jesse.zh...@amd.com>; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander <alexander.deuc...@amd.com>; Koenig, Christian <christian.koe...@amd.com>; Liu, Leo <leo....@amd.com>; Jiang, Sonny <sonny.ji...@amd.com> Subject: Re: [v3 4/5] drm/amd/pm: Update SMU v13.0.6 PPT caps initialization
On 8/20/2025 8:33 AM, Jesse.Zhang wrote: > Update the conditions for setting the SMU vcn reset caps in the SMU > v13.0.6 PPT initialization function. Specifically: > > - Add support for VCN reset capability for firmware versions 0x00558200 and > above when the program version is 0. > - Add support for VCN reset capability for firmware versions 0x05551800 and > above when the program version is 5. > > Signed-off-by: Jesse Zhang <jesse.zh...@amd.com> > Acked-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c > b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c > index 627a8188d868..9306bfe808e4 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c > @@ -437,7 +437,9 @@ static void smu_v13_0_6_init_caps(struct smu_context *smu) > ((pgm == 4) && (fw_ver >= 0x4557000))) > smu_v13_0_6_cap_set(smu, SMU_CAP(SDMA_RESET)); > > - if ((pgm == 4) && (fw_ver >= 0x04557100)) > + if (((pgm == 0) && (fw_ver >= 0x00558200)) || > + ((pgm == 4) && (fw_ver >= 0x04557100)) || > + ((pgm == 5) && (fw_ver >= 0x05551800))) pgm = 5 should be under smu_v13_0_14_init_caps(). No, Pgm 0, 4, and 5 are all 13.0.6. 13.0.14 is not ready yet and is being tested. Thanks Jesse Thanks, Lijo > smu_v13_0_6_cap_set(smu, SMU_CAP(VCN_RESET)); } >
